Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when empty key packages are found #398

Closed
wants to merge 5 commits into from
Closed

Conversation

neekolas
Copy link
Collaborator

@neekolas neekolas commented Aug 13, 2024

tl;dr

This makes the API more strict when fetching key packages. The current behaviour is to leave an empty element when the key package is not found, which then becomes an empty key package when the client deserializes the message.

Now when you request a bunch of key packages and one is not found it will return an error.

This is actually going to make xmtp/libxmtp#947 worse, since it'll hard fail without returning any results. I'd like to leave this on ice and merge it after we fix the root of the problem, which is that we should pair together registering an installation and the identity update so that it is impossible to submit an identity update creating an installation without registering a key package at the same time.

Maybe we don't even want to merge this ever and just handle the empty results better on the client.

@neekolas neekolas closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant