Error when empty key packages are found #398
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
This makes the API more strict when fetching key packages. The current behaviour is to leave an empty element when the key package is not found, which then becomes an empty key package when the client deserializes the message.
Now when you request a bunch of key packages and one is not found it will return an error.
This is actually going to make xmtp/libxmtp#947 worse, since it'll hard fail without returning any results. I'd like to leave this on ice and merge it after we fix the root of the problem, which is that we should pair together registering an installation and the identity update so that it is impossible to submit an identity update creating an installation without registering a key package at the same time.
Maybe we don't even want to merge this ever and just handle the empty results better on the client.