-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test case that checks publish-subscribe-query workflow across network nodes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkobetic
reviewed
Jul 7, 2022
mkobetic
reviewed
Jul 7, 2022
mkobetic
reviewed
Jul 7, 2022
mkobetic
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to do another round or two on this before it's ready but putting it up for 👀 in the meantime
https://github.com/xmtp-labs/hq/issues/551
go-libp2p
to latest version for feat: allow dialing wss peers using DNS multiaddrs libp2p/go-libp2p#1592queryFrom
andqueryLoop
logic into astore.Client
because theQuery
interface onwakustore.Store
was too restrictive with unexported fields on the args and results of it - it's also kind of weird that the logic that services requests was/is mixed together with the logic that makes requests / consumes the services of the protocolI guess it's worth calling out that we can easily put a lot of messages into our dev/prod DBs with a continuous version of this, but I don't think we should optimize for avoiding intake of test data, and just make sure we have cleanup/maintenance code in place for invalid and known test topics in the DBs (https://github.com/xmtp-labs/hq/issues/609).
I'm not 100% sure how this kind of test works when clients need to authenticate, @jazzz maybe you can weigh in on that 🙏