Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stylelint 15 #18

Merged
merged 7 commits into from
Jul 7, 2023
+7 −7
Merged

Support Stylelint 15 #18

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3e9053
Support Stylelint 15
fregante Feb 11, 2023
c3a3d7a
stylelint-order update
fregante Feb 11, 2023
8a69157
Node 18+
fregante Jul 7, 2023
095afc6
Node 18+ in package.json
fregante Jul 7, 2023
15e76fe
Update dependencies again
fregante Jul 7, 2023
4c5c5fa
16+ on CI
fregante Jul 7, 2023
b1b5a3d
16+ in engines
fregante Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@ jobs:
fail-fast: false
matrix:
node-version:
- 16
- 14
- 12
- 20
- 18
Copy link
Member Author

@fregante fregante Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 18 is already LTS: https://nodejs.org/en

In a separate breaking change, it might be worth dropping the rules, setting a stylelint v15 minimum, and adding prettier:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But 16 is also still LTS, and I generally prefer to support all active LTS versions.

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm install
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"url": "https://sindresorhus.com"
},
"engines": {
"node": ">=12"
"node": ">=18"
},
"scripts": {
"test": "xo && ava"
Expand Down Expand Up @@ -47,7 +47,7 @@
],
"dependencies": {
"stylelint-declaration-block-no-ignored-properties": "^2.5.0",
"stylelint-order": "^5.0.0"
"stylelint-order": "^6.0.2"
},
"devDependencies": {
"ava": "^4.1.0",
Expand Down