댓글 불러오기 동작에 트리거 추가 #2344
Merged
댓글 불러오기 동작에 트리거 추가 #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
closed this
ghost
reopened this
ghost
merged commit
dorami
added a commit
to daolcms/daolcms
that referenced
this pull request
Dec 23, 2018
dorami
added a commit
to daolcms/daolcms
that referenced
this pull request
Dec 23, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
예전에
document.getDocumentList에 트리거를 추가하여 여러 서드파티 자료에서 유용하게 사용하고 있습니다. 그러나 댓글에는 이와 같은 트리거가 없고, 스킨에서$oDocument->getComments()함수로 댓글을 불러오고 있다 보니 서드파티 자료에서 댓글 목록에 접근하려면 이미 렌더링된 HTML 결과물을 정규식으로 파싱해야 하는 불편을 겪습니다. 물론 이렇게 하면 성능과 정확성도 떨어집니다.이 PR에서는 라이믹스에서 지원하는 것과 동일한 트리거를 추가하여 서드파티 자료들이 댓글 목록에 편리하게 접근할 수 있도록 합니다.
commentModel클래스의getCommentList()메소드에before및after트리거 추가 (DB에서 불러오는 결과를 직접 조작할 필요가 있을 때 사용)documentItem클래스의getComments()메소드에after트리거 추가 (스킨에서 흔히 사용하는 댓글 목록에 간편하게 접근할 수 있도록 하여 편의성 강화)