Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes for OPeNDAP attributes #48

Merged
merged 18 commits into from
May 17, 2024
Merged

Some fixes for OPeNDAP attributes #48

merged 18 commits into from
May 17, 2024

Commits on Jun 2, 2023

  1. Debugging engine issues 

    I've gotten testing setup so that we can spin up Xpublish in the background and test real clients against it.

Works on xpublish-community#18
    @abkfenris
    abkfenris committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    347c052 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. escape a double quote in the interior of a string attribute

    @noaaroland
    noaaroland committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    52a9815 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. attribute might be type np.float32

    @noaaroland
    noaaroland committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    7eba967 View commit details
    Browse the repository at this point in the history

  2. do better with more attribute types

    @noaaroland
    noaaroland committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    e7e3a29 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Use test server to make sure that attributes with quotes are escaped 

    Builds upon xpublish-community#48 by merging in the live server testing from xpublish-community#20 (with a few of the failing tests disabled from there that are in response to another issue).

The live server has an additional dataset that is specifically focused on testings if attributes with double quotes are correctly round tripped via the OpenDAP plugin.

Merge branch 'test-server' into quote-with-server
    @abkfenris
    abkfenris committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d12c661 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from xpublish-community/quote-with-server 

    Use test server to make sure that attributes with quotes are escaped
    @noaaroland
    noaaroland authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    ada2729 View commit details
    Browse the repository at this point in the history

  3. add tests for quotes inside string attributes and 16 and 32 bit attri… 

    …butes
    @noaaroland
    noaaroland committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    cfb2780 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    08ac8a3 View commit details
    Browse the repository at this point in the history

  5. Update tests/server.py 

    Separate quote and casts tests.

Co-authored-by: Alex Kerney <abk@mac.com>
    @noaaroland @abkfenris
    noaaroland and abkfenris authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    410732e View commit details
    Browse the repository at this point in the history

  6. separate tests for quotes and attibute casting

    @noaaroland
    noaaroland committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    fda1626 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    aa8b1a1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Fix tests for cleaned up OpenDAP data types 

    Additionally fix pre-commit failures, and allow passing additional arguments into pytest/nox.
    @abkfenris
    abkfenris committed May 17, 2024
    Configuration menu
    Copy the full SHA
    cea662b View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e978cd8 View commit details
    Browse the repository at this point in the history

  3. Pin NetCDF4 to less than 1.6.0 in testing due to curl issues 

    xref: Unidata/netcdf-c#2459
xref: Unidata/netcdf4-python#1246
xref: pydata/xarray#7773
    @abkfenris
    abkfenris committed May 17, 2024
    Configuration menu
    Copy the full SHA
    15707cf View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'noaaroland/quote' into quote

    @abkfenris
    abkfenris committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5770a82 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed May 17, 2024
    Configuration menu
    Copy the full SHA
    230f634 View commit details
    Browse the repository at this point in the history

  6. Revert pinning netCDF4

    @abkfenris
    abkfenris committed May 17, 2024
    Configuration menu
    Copy the full SHA
    21ed418 View commit details
    Browse the repository at this point in the history

  7. Disable live server tests on Windows for now

    @abkfenris
    abkfenris committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2f9d5b7 View commit details
    Browse the repository at this point in the history