Bring test coverage to 100% #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
commented
Aug 8, 2020
benbovy
reviewed
Aug 10, 2020
| extract_zarr_variable_encoding, | ||
| ) | ||
| except ImportError: | ||
| # xarray <= 0.16.1 |
There was a problem hiding this comment.
Was it intentional to remove support for older xarray versions?
There was a problem hiding this comment.
It was. pydata/xarray#3897 fixed this upstream. Anything after 0.16 should be fine. Noticing now that we also need to bump the minimum version requirements in setup.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #38 so should be reviewed after the merge of that PR.