Skip to content

Commit

Permalink
core: launch_config: add warning for type= attrs on <param> tags on K…
Browse files Browse the repository at this point in the history
…inetic

See #138.
  • Loading branch information
xqms committed Jan 3, 2021
1 parent 020cc56 commit 46f7e19
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions rosmon_core/src/launch/launch_config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,22 @@ void LaunchConfig::parseParam(TiXmlElement* element, ParseContext& ctx, ParamCon

auto computeString = std::make_shared<std::future<std::string>>();

// On ROS Kinetic, type="..." is not respected for command= and textfile=
// attributes. We support that anyway, but print a nice warning for users.
// See GH issue #138.

#if !ROS_VERSION_MINIMUM(1,13,0)
if(type)
{
ctx.warning(
"On ROS Kinetic, roslaunch does not respect the type attribute on "
"<param> tags with command= or textfile= actions. However, rosmon "
"does support it and will create the properly typed parameter {}.",
fullName
);
}
#endif

if(command)
{
// Run a command and retrieve the results.
Expand Down

0 comments on commit 46f7e19

Please sign in to comment.