Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload get stuck forever #12

Closed
patrickelectric opened this issue Dec 8, 2020 · 3 comments
Closed

Upload get stuck forever #12

patrickelectric opened this issue Dec 8, 2020 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@patrickelectric
Copy link

more than 15 minutes trying to upload, got stuck, broke all others builds.
https://github.com/patrickelectric/ping-components/runs/1517505545?check_suite_focus=true

@owent
Copy link
Member

owent commented Dec 9, 2020

@patrickelectric There are too many files to upload in your workflow and they exceed the API rate limit of one token.

jobs:
  build:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        include:
        - os: macos-latest
          DEPLOY_PATH: pingviewer-Release.dmg
        - os: ubuntu-latest
          DEPLOY_PATH: pingviewer-Release.AppImage
        - os: windows-latest
          DEPLOY_PATH: deploy # This is a directory and it has many files.

    - name: Update continuous release
      uses: xresloader/upload-to-github-release@v1
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      with:
        tag_name: continuous
        file: ${{ matrix.DEPLOY_PATH }} # Try to upload the "deploy" directory with too many files
        tags: false
        overwrite: true
        prerelease: true
        verbose: true

Maybe it's better to archive the deploy into a zip and only upload one file?

@owent owent self-assigned this Dec 9, 2020
@owent owent added the help wanted Extra attention is needed label Dec 9, 2020
@patrickelectric
Copy link
Author

patrickelectric commented Dec 9, 2020

Thanks, I was able to fixed that creating the zip file.
But now sometimes I'm getting: "request xxxx failed, reason: socket hang up"

2020-12-09T13:18:43.5596950Z Delete file pattern: 
2020-12-09T13:18:43.5597900Z ============================= v3 API: uploadReleaseAsset =============================
2020-12-09T13:18:43.5599530Z Start uploading asset: pingviewer-Release.dmg(size: 24177563) ...
2020-12-09T13:18:43.5658520Z uploadReleaseAsset with length: 24177563
2020-12-09T13:18:44.0634250Z Upload asset: pingviewer-Release.dmg failed => request to https://uploads.github.com/repos/bluerobotics/ping-viewer/releases/33820216/assets?name=pingviewer-Release.dmg& failed, reason: socket hang up
2020-12-09T13:18:44.0637370Z HttpError: request to https://uploads.github.com/repos/bluerobotics/ping-viewer/releases/33820216/assets?name=pingviewer-Release.dmg& failed, reason: socket hang up
2020-12-09T13:18:44.0640170Z     at /Users/runner/work/_actions/xresloader/upload-to-github-release/v1/lib/index.js:13119:11
2020-12-09T13:18:44.0641160Z     at processTicksAndRejections (internal/process/task_queues.js:93:5)
2020-12-09T13:18:44.0642470Z Start uploading asset(1 retry): pingviewer-Release.dmg(size: 24177563) ...

That's happening almost every time when something get merged.

@owent
Copy link
Member

owent commented Dec 10, 2020

@patrickelectric Could you provide a log link without signature? The link upper is expired. I searched for reason: socket hang up and found serval issues such as electron-userland/electron-builder#4940 , request/request#2047 and etc. It seems to be a problem of nodejs or github API server and it happens on many tools (svenstaro/upload-release-action@v2 for example in your pipeline).

@owent owent closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants