-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions of dependencies #124
Conversation
@tdegeus maybe you have some thoughts about the issue with |
It is high time that I update to the new API, because most, if not all, code here can go. But in terms of issue, could you tell me what the issue is? |
We get the following error with
|
Ah, HighFive's CMake support is not to my liking. I tried to entirely rewrite it, but that gave too much resistance of the maintainers: BlueBrain/HighFive#257 . It would be great if you could report the issue in the library, there are quite some issues now, so maybe a critical mass can push for some overhaul. |
It's create here : https://github.com/BlueBrain/HighFive/blob/master/CMake/HighFiveTargetDeps.cmake . So one has to just cherry-pick from it. |
CMakeLists.txt
Outdated
@@ -248,7 +248,7 @@ endif() | |||
include(GNUInstallDirs) | |||
include(CMakePackageConfigHelpers) | |||
|
|||
install(TARGETS xtensor-io | |||
install(TARGETS xtensor-io libdeps | |||
EXPORT ${PROJECT_NAME}-targets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the way to go. libdeps should probably be installed by highfive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this would cause xtensor-io to install libdeps as part of its cmake, and therefore libdeps to be installed in xtensor-io's cmake.
7a031a2
to
852ba69
Compare
279ffab
to
04a1e61
Compare
We'll update highfive in another PR, as it requires some changes upstream. |
No description provided.