Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize loadAddon API and remove applyAddon #2076

Closed
Tyriar opened this issue May 11, 2019 · 0 comments · Fixed by #2377
Closed

Stabilize loadAddon API and remove applyAddon #2076

Tyriar opened this issue May 11, 2019 · 0 comments · Fixed by #2377
Assignees
@Tyriar
Labels
area/api breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run type/enhancement Features or improvements to existing features
Milestone
4.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 11, 2019

Added in #2065, let's remove experimental for loadAddon and remove applyAddon
@Tyriar Tyriar added type/enhancement Features or improvements to existing features type/debt Technical debt that could slow us down in the long run area/api labels May 11, 2019
@Tyriar Tyriar added this to the 4.0.0 milestone May 11, 2019
@Tyriar Tyriar mentioned this issue May 11, 2019
Merged
@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label May 11, 2019
@Tyriar Tyriar mentioned this issue May 30, 2019
Closed
@Tyriar Tyriar self-assigned this Aug 2, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 10, 2019
@Tyriar
Remove applyAddon, stabilize loadAddon
ba1274b 
Fixes xtermjs#2076
@Tyriar Tyriar mentioned this issue Aug 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/api breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Remove applyAddon, stabilize loadAddon Tyriar/xterm.js
1 participant
@Tyriar