Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webgl: Support allowTransparency option #2252

Closed
Tyriar opened this issue Jun 23, 2019 · 9 comments
Closed

Webgl: Support allowTransparency option #2252

Tyriar opened this issue Jun 23, 2019 · 9 comments
Labels
area/addon/webgl help wanted type/enhancement Features or improvements to existing features

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 23, 2019

Webgl addon added in #1790

I'm not sure what the state of this is currently.

@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/addon/webgl help wanted labels Jun 23, 2019
@Eugeny
Copy link
Member

Eugeny commented Oct 18, 2019

Any updates on this one? This and character joiner support are the only things keeping me from using the WebGL renderer as default in Terminus.

@Tyriar
Copy link
Member Author

Tyriar commented Oct 22, 2019

No updates, needs someone to look into it until I get time to invest into bringing it to vscode.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 25, 2019

Transparency seems to mostly work in from ef05a6a in #2560:

Screen Shot 2019-11-25 at 2 33 26 PM

(term.setOption('theme', { background: '#ff000050' }))
The scrollbar seems a bit off though and haven't tested very thoroughly.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 25, 2019

I tried to not draw a background rectangle at all as some colors ended up being off. There are two options for whoever wants too look into this in the future:

  • Explore not using a background color for the viewport (would be inconsistent with other renderers)
  • Explore not using a completely transparent background for webgl renderer (little worried about regressions here)

@Eugeny
Copy link
Member

Eugeny commented Nov 25, 2019

Works perfectly for me, including the scrollbar!

@Tyriar
Copy link
Member Author

Tyriar commented Nov 26, 2019

@Eugeny oh? The screenshot above of the demo is showing that the alpha color isn't correct as it's drawn twice (once in .xterm-viewport, once in canvas).

@Eugeny
Copy link
Member

Eugeny commented Nov 26, 2019

@Tyriar my primary concern was being able to have a completely transparent background - even in the current state transparent being drawn twice results in a usable transparent webgl xterm :)

@Tyriar
Copy link
Member Author

Tyriar commented Nov 26, 2019

@Eugeny ah ok, good 😃 I'll keep this open until the background color is correct though.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 30, 2022

I believe the background color problem is fixed, notice how the right of the row is the same color:

image

There have also been several fixes that have gone in for v5. Let's close this off and track individual issues as they come up as this one's a little ambiguous what's left to do.

@Tyriar Tyriar closed this as completed Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/webgl help wanted type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants