Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement canvas measure strategy #3449

Closed
Tyriar opened this issue Sep 1, 2021 · 1 comment · Fixed by #4929
Closed

Implement canvas measure strategy #3449

Tyriar opened this issue Sep 1, 2021 · 1 comment · Fixed by #4929
Assignees
Labels
area/performance type/bug Something is misbehaving type/enhancement Features or improvements to existing features
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 1, 2021

I have seen some reports like this:

image

I had a debug session with someone and there were some interesting findings:

  • It happened with monospace, Courier New, Consolas, Cascasia Code but not Arial (at least it wasn't obvious)
  • Switching fontSize (forcing the char atlas to get refreshed) did not fix the issue
  • Increasing the letter spacing mostly worked around the issue

Still not entirely sure why it's happening, but I believe handling this TODO will probably solve the issue and I can get it retested after we've done it:

// TODO: For supporting browsers we should also provide a CanvasCharDimensionsProvider that uses ctx.measureText

@Tyriar Tyriar added the type/bug Something is misbehaving label Sep 1, 2021
@Tyriar Tyriar added this to the 4.14.0 milestone Sep 1, 2021
@Tyriar Tyriar self-assigned this Sep 1, 2021
@Tyriar Tyriar modified the milestones: 4.14.0, 4.15.0 Sep 9, 2021
@meganrogge meganrogge modified the milestones: 4.15.0, 4.16.0 Nov 5, 2021
@Tyriar Tyriar removed this from the 4.16.0 milestone Dec 22, 2021
@anarchodin
Copy link

I get that display (Firefox on Linux, and it's very consistent), but if I use the mouse to get a highlight:

image

Remove the highlight and it goes right back to the original look. So whatever causes this, it changes when the highlighting is applied.

@Tyriar Tyriar added this to the 5.4.0 milestone Dec 29, 2023
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/performance labels Dec 29, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance type/bug Something is misbehaving type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants