-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize rendering of decorations in overview ruler #3703
Comments
When the buffer is full, could we just set the What I mean is let's say buffer length is 50. When line 51 is added, we set top of the canvas to |
For the case when the buffer isn't full, i was wondering if there's some transform (math) we could do to the canvas to shrink it height wise proportional to the amount that gets added instead of having to actually draw the decorations. |
We could essentially do this by drawing the canvas to itself via A better approach would probably be to do the color zone idea and explore shift that instead if performance is still poor after that change.
You could do some transform of the existing image but I think it suffers from the same problems, in addition to blurriness coming in as well. |
VS Code issue: microsoft/vscode#145751
Could repro this slowness by filling the buffer and then searching for a single letter, this is on a 12th gen i7 (fast modern CPU):
A similar thing happens when pressing enter in this state since we don't do any diffing, just clear and re-render.
Ideas to explore:
The text was updated successfully, but these errors were encountered: