Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overline follow ups #4529

Closed
Tyriar opened this issue May 21, 2023 · 0 comments · Fixed by #4532
Closed

Overline follow ups #4529

Tyriar opened this issue May 21, 2023 · 0 comments · Fixed by #4532
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
5.2.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 21, 2023

Overline was added in #4526 but the following parts were missed:

  • xterm.d.ts IBufferCell entry
  • xterm-headless.d.ts IBufferCell entry
  • String serialize
  • HTML serialize
  • SGR @vt comment entries
@Tyriar Tyriar added the type/bug Something is misbehaving label May 21, 2023
@Tyriar Tyriar added this to the 5.2.0 milestone May 21, 2023
@Tyriar Tyriar self-assigned this May 21, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 21, 2023
@Tyriar
Add isOverline to public API
b662824 
Part of xtermjs#4529
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 21, 2023
@Tyriar
Add overline to vt comments
325d133 
Part of xtermjs#4529
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 21, 2023
@Tyriar
Serialize overline
6188c07 
Fixes xtermjs#4529
@Tyriar Tyriar mentioned this issue May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Finish overline support Tyriar/xterm.js
1 participant
@Tyriar