Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add overview ruler #3676

Merged
merged 70 commits into from
Mar 16, 2022
Merged

add overview ruler #3676

merged 70 commits into from
Mar 16, 2022

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 9, 2022 •
edited
Loading

fixes #3632

@meganrogge meganrogge self-assigned this Mar 9, 2022
@meganrogge meganrogge requested a review from Tyriar March 9, 2022 14:49
@meganrogge meganrogge added this to the 4.19.0 milestone Mar 9, 2022
meganrogge
meganrogge commented Mar 9, 2022
View reviewed changes
src/browser/Terminal.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge marked this pull request as draft March 9, 2022 18:50
Tyriar
Tyriar requested changes Mar 11, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One theme I've noticed that I think we should move away from is the idea of buffer decorations vs scroll bar decorations. Instead there are decorations, all decorations are rendered in the buffer and some get rendered in the scroll bar. I think the latter is how it works but most of the code is structured in the other direction.

css/xterm.css Outdated Show resolved Hide resolved
css/xterm.css Outdated Show resolved Hide resolved
css/xterm.css Outdated Show resolved Hide resolved
demo/index.html Outdated Show resolved Hide resolved
src/browser/Terminal.ts Outdated Show resolved Hide resolved
src/browser/services/DecorationService.ts Outdated Show resolved Hide resolved
src/browser/services/DecorationService.ts Outdated Show resolved Hide resolved
src/browser/services/DecorationService.ts Outdated Show resolved Hide resolved
src/browser/services/DecorationService.ts Outdated Show resolved Hide resolved
src/browser/services/DecorationService.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge marked this pull request as ready for review March 14, 2022 14:10
meganrogge and others added 22 commits March 15, 2022 14:59
@meganrogge @Tyriar
Update typings/xterm.d.ts
5b87772 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update typings/xterm.d.ts
45ecc83 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update src/browser/Decorations/OverviewRulerRenderer.ts
b146ffd 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update typings/xterm.d.ts
fdc2bc4 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge
more cleanup
cee2411
@meganrogge
Merge branch 'merogge/scroll-bar-decorations' of https://github.com/m…
1c38f85 
…eganrogge/xterm.js into merogge/scroll-bar-decorations
@meganrogge @Tyriar
Update src/browser/Decorations/OverviewRulerRenderer.ts
4cc0db4 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update src/browser/Terminal.ts
e7baccd 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge
Merge branch 'master' into merogge/scroll-bar-decorations
9f6d4f5
@meganrogge
more cleanup
a9a6920
@meganrogge
Merge branch 'merogge/scroll-bar-decorations' of https://github.com/m…
19b212d 
…eganrogge/xterm.js into merogge/scroll-bar-decorations
@meganrogge
only update canvas dimensions when needed
8ccbef8
@meganrogge
add condition for when to update anchor
53c432d
@meganrogge
adjust size based on position
b05db37
@meganrogge @Tyriar
Update src/browser/Terminal.ts
d92e636 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update src/browser/Terminal.ts
035a7f7 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update src/browser/tsconfig.json
5777fbc 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update typings/xterm.d.ts
6f5008d 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update typings/xterm.d.ts
a4f830a 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge
use this._width instead of options
22d889a
@meganrogge
tweak demo
963ed59
@meganrogge
Merge branch 'merogge/scroll-bar-decorations' of https://github.com/m…
7f85922 
…eganrogge/xterm.js into merogge/scroll-bar-decorations
Tyriar
Tyriar approved these changes Mar 16, 2022
View reviewed changes
demo/client.ts Outdated Show resolved Hide resolved
demo/client.ts Show resolved Hide resolved
@meganrogge meganrogge mentioned this pull request Mar 16, 2022
Closed
@meganrogge meganrogge merged commit 3870507 into xtermjs:master Mar 16, 2022
This was referenced Jul 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.

Allow decorations to show up in the scroll bar
2 participants
@meganrogge @Tyriar