Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose urlRegex in the public .d.ts file. #3719

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Expose urlRegex in the public .d.ts file. #3719

merged 2 commits into from
Mar 30, 2022

Conversation

LuckyGeck
Copy link
Contributor

@LuckyGeck LuckyGeck commented Mar 30, 2022 •
edited
Loading

This makes it possible to pass a regex when working against a .d.ts file instead of directly against a WebLinksAddon.ts

Tyriar
Tyriar approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. I also removed duplication with the interface since I noticed they existed in 2 forms as well.

@Tyriar Tyriar added this to the 4.19.0 milestone Mar 30, 2022
@Tyriar Tyriar merged commit 4319df0 into xtermjs:master Mar 30, 2022
@LuckyGeck LuckyGeck deleted the addregex branch March 30, 2022 15:08
This was referenced Jul 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LuckyGeck @Tyriar