Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FINALLY fix blurry canvas/webgl renderer issues due to device pixel rounding errors 🎉 #3926

Merged
merged 7 commits into from
Jul 28, 2022
Merged

FINALLY fix blurry canvas/webgl renderer issues due to device pixel rounding errors 🎉 #3926

merged 7 commits into from
Jul 28, 2022

Commits on Jul 24, 2022

  1. Fix device pixel rounding errors in webgl renderer 

    This uses the ResizeObserver devicePixelContentBoxSize API in order to
fetch the exact device pixel dimensions from the browser. The old
possibly blurry behavior is used as a fallback if that API is not
available.

Part of xtermjs#2662
Part of microsoft/vscode#85154
    @Tyriar
    Tyriar committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    cb10aad View commit details
    Browse the repository at this point in the history

  2. Fix device pixel value in canvas renderer

    @Tyriar
    Tyriar committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    e254713 View commit details
    Browse the repository at this point in the history

  3. typescript@4.7 

    Required for devicePixelContentBoxSize ResizeObserver API
    @Tyriar
    Tyriar committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    3d6c25b View commit details
    Browse the repository at this point in the history

  4. ts-loader update, correct css cell dimension error

    @Tyriar
    Tyriar committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    ad84044 View commit details
    Browse the repository at this point in the history

  5. Refactor to share observeDevicePixelDimensions

    @Tyriar
    Tyriar committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    47b1fdd View commit details
    Browse the repository at this point in the history

  6. Fix canvas device pixel dimension setting

    @Tyriar
    Tyriar committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    0165c36 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Merge remote-tracking branch 'upstream/master' into rounding

    @Tyriar
    Tyriar committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    437c8aa View commit details
    Browse the repository at this point in the history