Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocha test explorer #3966

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Fix mocha test explorer #3966

merged 3 commits into from
Jul 30, 2022

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Jul 30, 2022

Introduced by #3934. Sort of alternative solution to keep the mocha test explorer working for unit tests.
Somebody needs to check if I didn't break the api tests again.
When mocha doesn't have a config flag passed, it takes by default the nearest file it can find.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the revert, test-api still works with this though👍

.mocharc-default.yml Outdated Show resolved Hide resolved
@Tyriar Tyriar added this to the 5.0.0 milestone Jul 30, 2022
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, super clean 🙂

@silamon
Copy link
Contributor Author

silamon commented Jul 30, 2022

Don't merge this branch yet. The mocha test explorer didn't got all the functionality back it had with the config file.

@Tyriar Tyriar marked this pull request as draft July 30, 2022 14:19
@Tyriar
Copy link
Member

Tyriar commented Jul 30, 2022

@silamon np, mark ready for review when it's ready to make sure I don't merge early

@silamon silamon marked this pull request as ready for review July 30, 2022 14:28
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works 👍

@Tyriar Tyriar merged commit d3b3357 into xtermjs:master Jul 30, 2022
@silamon silamon deleted the mochaunittestback branch October 16, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants