-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mocha test explorer #3966
Fix mocha test explorer #3966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the revert, test-api still works with this though👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, super clean 🙂
Don't merge this branch yet. The mocha test explorer didn't got all the functionality back it had with the config file. |
@silamon np, mark ready for review when it's ready to make sure I don't merge early |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works 👍
Introduced by #3934. Sort of alternative solution to keep the mocha test explorer working for unit tests.
Somebody needs to check if I didn't break the api tests again.
When mocha doesn't have a config flag passed, it takes by default the nearest file it can find.