Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix demo when loading webgl addon throws #3983

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Fix demo when loading webgl addon throws #3983

merged 4 commits into from
Aug 3, 2022

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Jul 31, 2022

WebGL throws error on initialization in some cases, breaking the demo.

Tyriar
Tyriar reviewed Jul 31, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what the error is that causes this?

@silamon
Copy link
Contributor Author

silamon commented Aug 1, 2022

Do you know what the error is that causes this?

Nothing fixable, it's just not supported (browser or hardware).

@Tyriar Tyriar added this to the 5.0.0 milestone Aug 3, 2022
@Tyriar Tyriar merged commit 830f8f3 into xtermjs:master Aug 3, 2022
@Tyriar Tyriar changed the title Fix demo Fix demo when loading webgl addon throws Aug 3, 2022
@silamon silamon mentioned this pull request Oct 9, 2022
Merged
@silamon silamon deleted the fixdemo branch October 16, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@silamon @Tyriar