Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share rgba vars throughout Color.ts, fast setTheme parseColor #4140

Merged
merged 3 commits into from
Sep 24, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 24, 2022

General speed improvement, the main one being startup.

Before (macbook, no CPU throttle):

Screen Shot 2022-09-24 at 9 54 55 am

After:

Screen Shot 2022-09-24 at 9 57 42 am

This removed the allowTransparency code, it didn't actually do much
before, just whether the 'advanced parsing' would allow transparency.
Since we already do the common formats, I'm not even sure what other
format it could be.
@Tyriar Tyriar added this to the 5.1.0 milestone Sep 24, 2022
@Tyriar Tyriar self-assigned this Sep 24, 2022
@Tyriar Tyriar merged commit 8b323bb into xtermjs:master Sep 24, 2022
Tyriar added a commit to microsoft/vscode that referenced this pull request Sep 26, 2022
- Optimize critical I/O path for input latency xtermjs/xterm.js#4145
- Add PriorityTaskQueue xtermjs/xterm.js#4144
- Use the browser's IdleDeadline to determine max task time xtermjs/xterm.js#4143
- Defer paused renderer resize to idle callback xtermjs/xterm.js#4142
- Do char atlas warmup via new IdleTaskQueue xtermjs/xterm.js#4141
- Share rgba vars throughout Color.ts, fast setTheme parseColor xtermjs/xterm.js#4140
- Optimize contexts for reading frequently xtermjs/xterm.js#4137
- Fix width of upper 1/8 block char xtermjs/xterm.js#4134

Fixes #161323
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
- Optimize critical I/O path for input latency xtermjs/xterm.js#4145
- Add PriorityTaskQueue xtermjs/xterm.js#4144
- Use the browser's IdleDeadline to determine max task time xtermjs/xterm.js#4143
- Defer paused renderer resize to idle callback xtermjs/xterm.js#4142
- Do char atlas warmup via new IdleTaskQueue xtermjs/xterm.js#4141
- Share rgba vars throughout Color.ts, fast setTheme parseColor xtermjs/xterm.js#4140
- Optimize contexts for reading frequently xtermjs/xterm.js#4137
- Fix width of upper 1/8 block char xtermjs/xterm.js#4134

Fixes microsoft#161323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant