Log a warning if task queues exceed deadline by 20ms #4293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4292
This shouldn't happen in practice if we do good, the idea is for these warnings to get reported back to us so we can split tasks up further.
Here's a simulation I did to test it by tweaking the number to 5ms and changing the texture atlas warmup to perform in a single callback:
When profiling you don't get a full trace, but this is what it looks like normally (at least in dev):