Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove AccessibleBuffer #4427

Merged
merged 5 commits into from
Mar 2, 2023
Merged

remove AccessibleBuffer #4427

merged 5 commits into from
Mar 2, 2023

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 2, 2023 •
edited
Loading

It only complicated things to have this in xterm.js. For example, see

#4426 (comment)

@meganrogge meganrogge requested a review from Tyriar March 2, 2023 18:10
@meganrogge meganrogge self-assigned this Mar 2, 2023
@meganrogge meganrogge added this to the 5.2.0 milestone Mar 2, 2023
meganrogge
meganrogge commented Mar 2, 2023
View reviewed changes
src/browser/Terminal.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge added this pull request to the merge queue Mar 2, 2023
@meganrogge meganrogge removed this pull request from the merge queue due to a manual request Mar 2, 2023
@meganrogge meganrogge merged commit 4037b94 into xtermjs:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@meganrogge @Tyriar