Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more granular windowsPty option #4539

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 29, 2023

Context: microsoft/vscode#134448

This adds a new option windowsPty that replaces/deprecates windowsOption. It gives more granularity around the backend pty info on Windows as enabling heuristics/workarounds is more that just a simple flag now that certain things have been fixed in ConPTY.

@Tyriar Tyriar added this to the 5.2.0 milestone May 29, 2023
@Tyriar Tyriar self-assigned this May 29, 2023
@Tyriar
Copy link
Member Author

Tyriar commented May 29, 2023

Will push this and adopt in VS Code in a week or so when we branch off the release.

@Tyriar Tyriar marked this pull request as ready for review May 29, 2023 16:51
@Tyriar Tyriar requested a review from meganrogge May 29, 2023 16:51
@Tyriar Tyriar merged commit 380e680 into xtermjs:master Jun 7, 2023
@Tyriar Tyriar deleted the tyriar/windowsPty branch June 8, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant