-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions #4693
GitHub Actions #4693
Conversation
@Tyriar Wanna move away from azure CI? Tbh I found the gh-action based CI more reliable (from other projects), than azure in xtermjs. I kinda never get timeout errors on gh-actions, while azure seems to cause testing issue from high load sometimes. |
I do, mainly because it's a little more integrated and easier to get to the failures. It's looking quite nice so far, will see how publish goes |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
.github/workflows/ci.yml
Outdated
- name: Integration tests (Chromium) | ||
run: yarn test-api-chromium --headless --forbid-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would merging the browser tests into one container defintion help to speedup things?
I also wonder, if we should add back safari/webkit testing at some point, though I dont recall, why we removed it in the first place. We kinda have a blind spot there atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If agents all get provisioned then as much parallelization as possible would be the fastest. The integration tests for each browser takes several minutes.
I think for webkit there were issues when it was originally set up and never looked into after that.
--ignore-scripts ends up preventing node-pty from building, to optimize we need to split these up more
Fixes #3297
Typical
master
build on Azure Pipelines ~15 minutes:After: