Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct graphemes addon readme and typings #4809

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Correct graphemes addon readme and typings #4809

merged 2 commits into from
Sep 16, 2023

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Sep 16, 2023 •
edited
Loading

Small copy-paste fix for the typings file and readme file in the new graphemes addon.

@silamon silamon changed the title Correct typing graphemes Correct typing graphemes addon Sep 16, 2023
@silamon silamon changed the title Correct typing graphemes addon Correct graphemes addon readme and typings Sep 16, 2023
@PerBothner
Copy link
Contributor

I'm OK with these changes.

One might argue that it is confusing to use singular "Grapheme" in UnicodeGraphemeProvider and plural "Graphemes" in UnicodeGraphemesAddon.ts - and I would not disagree. It would probably be better to pick one or the other.

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 16, 2023
@Tyriar Tyriar self-assigned this Sep 16, 2023
Tyriar
Tyriar approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For UnicodeGraphemeProvider using singular isn't a big deal as it's an internal file, I guess making it consistently plural would be better though.

@Tyriar Tyriar merged commit 03f1336 into xtermjs:master Sep 16, 2023
18 checks passed
@silamon silamon deleted the correct-typing-graphemes branch September 17, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@silamon @PerBothner @Tyriar