Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addCustomWheelEventHandler API #4913

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 12, 2023

I opted for consistency with the key event handler over our more modern approach, we can migrate them at the same time if we end up returning a disposable.

See microsoft/vscode#76381

I opted for consistency with the key event handler over our more modern
approach, we can migrate them at the same time if we end up returning
a disposable.

See microsoft/vscode#76381
@Tyriar Tyriar added this to the 5.4.0 milestone Dec 12, 2023
@Tyriar Tyriar self-assigned this Dec 12, 2023
@Tyriar Tyriar merged commit 1f15c47 into xtermjs:master Dec 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant