Use Unsafe.BitCast for generic span casting

xtqqczze · Oct 23, 2024 · 29b55bd · 29b55bd · xtqqczze · Oct 23, 2024
1 parent 24dd2bc
commit 29b55bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormat.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormat.cs
@@ -754,7 +754,7 @@ internal static void AppendChar<TChar>(ref ValueListBuilder<TChar> result, char
             {
                 Debug.Assert(typeof(TChar) == typeof(byte));
                 var r = new Rune(ch);
-                r.EncodeToUtf8(MemoryMarshal.AsBytes(result.AppendSpan(r.Utf8SequenceLength)));
+                r.EncodeToUtf8(Unsafe.BitCast<Span<TChar>, Span<byte>>(result.AppendSpan(r.Utf8SequenceLength)));
             }
         }
 

diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/HebrewNumber.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/HebrewNumber.cs
@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Numerics;
+using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Text;
 
@@ -211,7 +212,7 @@ internal static void Append<TChar>(ref ValueListBuilder<TChar> outputBuffer, int
                 else
                 {
                     Debug.Assert(typeof(TChar) == typeof(byte));
-                    Rune.DecodeLastFromUtf8(MemoryMarshal.AsBytes(outputBuffer.AsSpan()), out Rune value, out int bytesConsumed);
+                    Rune.DecodeLastFromUtf8(Unsafe.BitCast<ReadOnlySpan<TChar>, ReadOnlySpan<byte>>(outputBuffer.AsSpan()), out Rune value, out int bytesConsumed);
                     outputBuffer.Length -= bytesConsumed;
                     outputBuffer.Append(TChar.CastFrom('"'));
                     DateTimeFormat.AppendChar(ref outputBuffer, (char)value.Value);