Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(start): start section to trim correct bytes #493

Merged
merged 1 commit into from
Feb 24, 2019
Merged

fix(start): start section to trim correct bytes #493

merged 1 commit into from
Feb 24, 2019

Conversation

sendilkumarn
Copy link
Contributor

@sendilkumarn sendilkumarn commented Feb 24, 2019 •
edited
Loading

r? @xtuc

@sendilkumarn sendilkumarn mentioned this pull request Feb 24, 2019
Closed
xtuc
xtuc approved these changes Feb 24, 2019
View reviewed changes
Copy link
Owner

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works, thank you!

I'm not sure how to unit test but I'll add more decoding tests later.

@xtuc xtuc merged commit 7681e90 into xtuc:master Feb 24, 2019
@xtuc xtuc deleted the fix-start branch February 24, 2019 09:33
@xtuc
Copy link
Owner

xtuc commented Feb 24, 2019

Published version 1.8.5.

@alexcrichton
Copy link

@xtuc does webpack also need to be updated to pull in the changes for this module?

@alexcrichton alexcrichton mentioned this pull request Feb 25, 2019
Merged
@xtuc
Copy link
Owner

xtuc commented Feb 25, 2019

Yes, I expected a bot to pick it up but I'll do it manually.

@fitzgen fitzgen mentioned this pull request Feb 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sendilkumarn @xtuc @alexcrichton