[multi-node] Fix sage infer hang #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxsbupt
approved these changes
May 17, 2023
lxsbupt
reviewed
May 17, 2023
paddle/fluid/framework/data_feed.cu
Outdated
| if (local_reach_end) { | ||
| conf_.buf_size /= 2; | ||
| } | ||
| total_row_[0] = conf_.buf_size; |
There was a problem hiding this comment.
再提一个建议，这里最好不要修改buf_size_。
如果后面还有其他类型节点需要infer，这里buf_size_得不到reset，不友好。
建议这样，
if (global_reach_end)
total_row_[0] = device_key_size - global_infer_node_type_start[infer_cursor];
else
remain = device_key_size - global_infer_node_type_start[infer_cursor];
if local_reach_end
total_row_[0] = remain / 2;
else
total_row_[0] = remain;
There was a problem hiding this comment.
done，不过最后那个else那里，应该是total_row_[0] = conf_.buf_size;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Describe