forked from PaddlePaddle/Paddle
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split graph table #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add actual neighbor sample result
…ddle into gpu_graph_engine2
xuewujiao
reviewed
May 24, 2022
@@ -122,11 +122,12 @@ node_list[7]-> node_id:9, neighbor_size:1, neighbor_offset:14 | |||
node_list[8]-> node_id:17, neighbor_size:1, neighbor_offset:15 | |||
*/ | |||
struct NeighborSampleQuery { | |||
int gpu_id; | |||
int gpu_id, idx; | |||
int64_t *key; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是命名为src_nodes更好
xuewujiao
reviewed
May 24, 2022
@@ -122,11 +122,12 @@ node_list[7]-> node_id:9, neighbor_size:1, neighbor_offset:14 | |||
node_list[8]-> node_id:17, neighbor_size:1, neighbor_offset:15 | |||
*/ | |||
struct NeighborSampleQuery { | |||
int gpu_id; | |||
int gpu_id, idx; | |||
int64_t *key; | |||
int sample_size; | |||
int len; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
len应该放在紧临src_nodes后面?这样更清楚的表示为src_nodes的长度
seemingwang
force-pushed
the
gpu_graph_engine2
branch
from
May 25, 2022 02:43
18f17ae
to
dc8dbf2
Compare
xuewujiao
approved these changes
May 25, 2022
xuewujiao
approved these changes
May 25, 2022
xuewujiao
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
split graph table