Skip to content

Commit

Permalink
[aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualifer in MIR…
Browse files Browse the repository at this point in the history
…RORV6 table. (sonic-net#2668)

What I did
Fixed issue sonic-net#2204

Why I did it
Community test case "sonic-mgmt/tests/everflow/everflow/test_everflow_per_interface.py::test_everflow_per_interface[ipv6]"
fails for IPV6 traffic with below error.

Feb 15 09:06:44.205490 sonic ERR swss#orchagent: :- validateAclRuleMatch: Match SAI_ACL_ENTRY_ATTR_FIELD_IN_PORTS in rule RULE_1 is not supported by table EVERFLOWV6
Feb 15 09:06:44.206501 sonic ERR swss#orchagent: :- doAclRuleTask: Unknown or invalid rule attribute 'IN_PORTS : Ethernet2,Ethernet3,Ethernet8,Ethernet9'
Feb 15 09:06:44.207624 sonic ERR swss#orchagent: :- doAclRuleTask: Failed to create ACL rule. Rule configuration is invalid

How I verified it
Verify the Community Testcase with IPV6 traffic is passing.

Signed-off-by: rajkumar38 <rpennadamram@marvell.com>
  • Loading branch information
rajkumar38 authored Feb 27, 2023
1 parent 35a7ab0 commit cfcd40c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion orchagent/aclorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3216,7 +3216,7 @@ void AclOrch::initDefaultTableTypes()
* | -----------------------------------------------------------------|
* | MATCH_ETHERTYPE | √ | √ | |
* |------------------------------------------------------------------|
* | MATCH_IN_PORTS | √ | √ | |
* | MATCH_IN_PORTS | √ | √ | |
* |------------------------------------------------------------------|
*/

Expand Down Expand Up @@ -3277,6 +3277,7 @@ void AclOrch::initDefaultTableTypes()
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_L4_SRC_PORT))
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_L4_DST_PORT))
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_TCP_FLAGS))
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_IN_PORTS))
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_DSCP))
.withMatch(make_shared<AclTableRangeMatch>(set<sai_acl_range_type_t>{
{SAI_ACL_RANGE_TYPE_L4_SRC_PORT_RANGE, SAI_ACL_RANGE_TYPE_L4_DST_PORT_RANGE}}))
Expand Down
1 change: 1 addition & 0 deletions tests/test_mirror_ipv6_separate.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ def test_MirrorV6TableCreation(self, dvs, testlog):
"SAI_ACL_TABLE_ATTR_FIELD_L4_DST_PORT",
"SAI_ACL_TABLE_ATTR_FIELD_TCP_FLAGS",
"SAI_ACL_TABLE_ATTR_FIELD_DSCP",
"SAI_ACL_TABLE_ATTR_FIELD_IN_PORTS",
"SAI_ACL_TABLE_ATTR_FIELD_OUTER_VLAN_ID"
]

Expand Down

0 comments on commit cfcd40c

Please sign in to comment.