xunit/xunit#2846: Optional parameters should not trigger xUnit1041

xunit · Dec 11, 2023 · 4db8815 · 4db8815
1 parent 9ca8812
commit 4db8815
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/xunit.analyzers.tests/Analyzers/X1000/EnsureFixturesHaveASourceTests.cs b/src/xunit.analyzers.tests/Analyzers/X1000/EnsureFixturesHaveASourceTests.cs
@@ -17,7 +17,7 @@ public NonTestClass(object _) { }
 		}
 	}
 
-	public class SupportedNonFixtureTypes
+	public class SupportedNonFixtureData
 	{
 		[Theory]
 		[InlineData("")]
@@ -55,6 +55,21 @@ [Fact] public void TestMethod() {{ }}
 
 			await Verify.VerifyAnalyzerV3(source);
 		}
+
+		[Fact]
+		public async void OptionalParameter_DoesNotTrigger()
+		{
+			var source = @"
+using Xunit;
+
+public class TestClass {
+    public TestClass(bool value = true) { }
+
+    [Fact] public void TestMethod() { }
+}";
+
+			await Verify.VerifyAnalyzer(source);
+		}
 	}
 
 	public class ClassFixtures

diff --git a/src/xunit.analyzers/X1000/EnsureFixturesHaveASource.cs b/src/xunit.analyzers/X1000/EnsureFixturesHaveASource.cs
@@ -104,7 +104,7 @@ bool MatchCollectionDefinition(INamedTypeSymbol symbol) =>
 						.Select(a => a.ConstructorArguments[0].Value as ITypeSymbol)
 				);
 
-			foreach (var parameter in ctors[0].Parameters.Where(p => !validConstructorArgumentTypes.Contains(p.Type)))
+			foreach (var parameter in ctors[0].Parameters.Where(p => !p.IsOptional && !validConstructorArgumentTypes.Contains(p.Type)))
 				context.ReportDiagnostic(
 					Diagnostic.Create(
 						Descriptors.X1041_EnsureFixturesHaveASource,