Fix false-positive errors from xunit/xunit#2826 #170
Conversation
src/xunit.analyzers.tests/Analyzers/X1000/MemberDataShouldReferenceValidMemberTests.cs
Show resolved
Hide resolved
| if (type is IArrayTypeSymbol arrayType && arrayType.ElementType.SpecialType == SpecialType.System_Object) | ||
| return initializer.Expressions.ToList(); | ||
|
|
||
| return new List<ExpressionSyntax> { argumentExpression }; |
There was a problem hiding this comment.
@JamesTerwilliger could this be shortcutted by inverting the if on 244 and executing the if between line 231 and 232? then in this case, it does not have to determine initializer. Thoughts?
There was a problem hiding this comment.
@viceroypenguin I had it this way thinking that initializer being not null means that it is an array type, and that the semantic model call is likely more expensive. Said differently, the initializer being null is the short-circuit that I want so that the (I believe) expensive call is only done if need be.
There was a problem hiding this comment.
Good reasoning; and I'll trust your experience with this code, not having enough experience with touching the semanticModel in analyzers. LGTM
bradwilson
changed the title
|
Thanks! |
This PR fixes a regression introduced by xunit/xunit#2826. It tests to see if the argument to the MemberDataAttribute should be treated as a single argument rather than a params array.
@bradwilson FYI