Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename variable name to cluster_domain #53

Closed
fredleger opened this issue May 3, 2021 · 1 comment · Fixed by #54
Closed

rename variable name to cluster_domain #53

fredleger opened this issue May 3, 2021 · 1 comment · Fixed by #54

Comments

@fredleger
Copy link

I do think it will be clearer if var.name is renamed in cluster_domain or similar.

Get tricked by this until i realised that my services where all ending in aws.cluster :-)
@xunleii
Copy link
Owner

xunleii commented May 4, 2021 •
edited
Loading

Oops, I don't know why it was clear in my mind when I wrote this 🤔 ... So, cluster_domain or cluster_name seems clearly better than just name (even if it's documented).

Thanks for your issue 😄.

NOTE: However, we have to keep in mind that this will break compatibility (so we also have to keep name, until the next major release).
NOTE²: I think we can release a major release just after this one

xunleii added a commit that referenced this issue Jun 23, 2021
@xunleii
refactor(inputs): use cluster_domain instead of name
971c578 
The use of `cluster_domain` is clearer than just` name`, which could be interpreted as something
else.

BREAKING CHANGE: Deprecation of `name` variable

fix #53
xunleii added a commit that referenced this issue Jun 23, 2021
@xunleii
refactor(inputs): use cluster_domain instead of name
ce33ef7 
The use of `cluster_domain` is clearer than just` name`, which could be interpreted as something
else.

BREAKING CHANGE: Deprecation of `name` variable

fix #53
xunleii added a commit that referenced this issue Jun 23, 2021
@xunleii
refactor(inputs): use cluster_domain instead of name
383fe5b 
The use of `cluster_domain` is clearer than just` name`, which could be interpreted as something
else.

BREAKING CHANGE: Deprecation of `name` variable

fix #53
@xunleii xunleii linked a pull request Jun 23, 2021 that will close this issue
Resolve issues #52 & #53 #54
Merged
xunleii added a commit that referenced this issue Jun 24, 2021
@xunleii
Merge pull request #54 from xunleii/fix/resolve-#53-#52
2031663 
Resolve issues #52 & #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve issues #52 & #53 xunleii/terraform-module-k3s
2 participants
@fredleger @xunleii