-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix k3s_install_env_vars and hcloud-k3s example issues #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of Terraform used empty provider blocks ("proxy provider configurations") for child modules to declare their need to be passed a provider configuration by their callers. That approach was ambiguous and is now deprecated.
Because we can iterate over null, I prefer to have an empty map as default value for k3s_install_env_vars
Terraform CI/CD
|
Terraform CI/CD (examples/civo-k3s)
|
xunleii
added
the
terraform:plan
Invoke Terraform plan workflow on the current PR
label
May 17, 2023
Terraform CI/CD (examples/hcloud-k3s)
Terraform Plan outputdata.hcloud_image.ubuntu: Reading...
module.k3s.data.http.k3s_version: Reading...
module.k3s.data.http.k3s_version: Read complete after 0s [id=https://update.k3s.io/v1-release/channels]
module.k3s.data.http.k3s_installer: Reading...
data.hcloud_image.ubuntu: Read complete after 0s [name=ubuntu-20.04]
module.k3s.data.http.k3s_installer: Read complete after 1s [id=https://raw.githubusercontent.com/rancher/k3s/v1.27.1+k3s1/install.sh]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# hcloud_network.k3s will be created
+ resource "hcloud_network" "k3s" {
+ delete_protection = false
+ id = (known after apply)
+ ip_range = "10.0.0.0/8"
+ name = "k3s-network"
}
# hcloud_network_subnet.k3s_nodes will be created
+ resource "hcloud_network_subnet" "k3s_nodes" {
+ gateway = (known after apply)
+ id = (known after apply)
+ ip_range = "10.254.1.0/24"
+ network_id = (known after apply)
+ network_zone = "eu-central"
+ type = "server"
}
# hcloud_server.agents[0] will be created
+ resource "hcloud_server" "agents" {
+ allow_deprecated_images = false
+ backup_window = (known after apply)
+ backups = false
+ datacenter = (known after apply)
+ delete_protection = false
+ firewall_ids = (known after apply)
+ id = (known after apply)
+ ignore_remote_firewall_ids = false
+ image = "ubuntu-20.04"
+ ipv4_address = (known after apply)
+ ipv6_address = (known after apply)
+ ipv6_network = (known after apply)
+ keep_disk = false
+ labels = {
+ "engine" = "k3s"
+ "node_type" = "agent"
+ "nodepool" = "gpu"
+ "provisioner" = "terraform"
}
+ location = (known after apply)
+ name = "k3s-agent-0"
+ rebuild_protection = false
+ server_type = "cx11"
+ ssh_keys = (known after apply)
+ status = (known after apply)
}
# hcloud_server.agents[1] will be created
+ resource "hcloud_server" "agents" {
+ allow_deprecated_images = false
+ backup_window = (known after apply)
+ backups = false
+ datacenter = (known after apply)
+ delete_protection = false
+ firewall_ids = (known after apply)
+ id = (known after apply)
+ ignore_remote_firewall_ids = false
+ image = "ubuntu-20.04"
+ ipv4_address = (known after apply)
+ ipv6_address = (known after apply)
+ ipv6_network = (known after apply)
+ keep_disk = false
+ labels = {
+ "engine" = "k3s"
+ "node_type" = "agent"
+ "nodepool" = "general"
+ "provisioner" = "terraform"
}
+ location = (known after apply)
+ name = "k3s-agent-1"
+ rebuild_protection = false
+ server_type = "cx11"
+ ssh_keys = (known after apply)
+ status = (known after apply)
}
# hcloud_server.agents[2] will be created
+ resource "hcloud_server" "agents" {
+ allow_deprecated_images = false
+ backup_window = (known after apply)
+ backups = false
+ datacenter = (known after apply)
+ delete_protection = false
+ firewall_ids = (known after apply)
+ id = (known after apply)
+ ignore_remote_firewall_ids = false
+ image = "ubuntu-20.04"
+ ipv4_address = (known after apply)
+ ipv6_address = (known after apply)
+ ipv6_network = (known after apply)
+ keep_disk = false
+ labels = {
+ "engine" = "k3s"
+ "node_type" = "agent"
+ "nodepool" = "general"
+ "provisioner" = "terraform"
}
+ location = (known after apply)
+ name = "k3s-agent-2"
+ rebuild_protection = false
+ server_type = "cx11"
+ ssh_keys = (known after apply)
+ status = (known after apply)
}
# hcloud_server.control_planes[0] will be created
+ resource "hcloud_server" "control_planes" {
+ allow_deprecated_images = false
+ backup_window = (known after apply)
+ backups = false
+ datacenter = (known after apply)
+ delete_protection = false
+ firewall_ids = (known after apply)
+ id = (known after apply)
+ ignore_remote_firewall_ids = false
+ image = "ubuntu-20.04"
+ ipv4_address = (known after apply)
+ ipv6_address = (known after apply)
+ ipv6_network = (known after apply)
+ keep_disk = false
+ labels = {
+ "engine" = "k3s"
+ "node_type" = "control-plane"
+ "provisioner" = "terraform"
}
+ location = (known after apply)
+ name = "k3s-control-plane-0"
+ rebuild_protection = false
+ server_type = "cx11"
+ ssh_keys = (known after apply)
+ status = (known after apply)
}
# hcloud_server.control_planes[1] will be created
+ resource "hcloud_server" "control_planes" {
+ allow_deprecated_images = false
+ backup_window = (known after apply)
+ backups = false
+ datacenter = (known after apply)
+ delete_protection = false
+ firewall_ids = (known after apply)
+ id = (known after apply)
+ ignore_remote_firewall_ids = false
+ image = "ubuntu-20.04"
+ ipv4_address = (known after apply)
+ ipv6_address = (known after apply)
+ ipv6_network = (known after apply)
+ keep_disk = false
+ labels = {
+ "engine" = "k3s"
+ "node_type" = "control-plane"
+ "provisioner" = "terraform"
}
+ location = (known after apply)
+ name = "k3s-control-plane-1"
+ rebuild_protection = false
+ server_type = "cx11"
+ ssh_keys = (known after apply)
+ status = (known after apply)
}
# hcloud_server.control_planes[2] will be created
+ resource "hcloud_server" "control_planes" {
+ allow_deprecated_images = false
+ backup_window = (known after apply)
+ backups = false
+ datacenter = (known after apply)
+ delete_protection = false
+ firewall_ids = (known after apply)
+ id = (known after apply)
+ ignore_remote_firewall_ids = false
+ image = "ubuntu-20.04"
+ ipv4_address = (known after apply)
+ ipv6_address = (known after apply)
+ ipv6_network = (known after apply)
+ keep_disk = false
+ labels = {
+ "engine" = "k3s"
+ "node_type" = "control-plane"
+ "provisioner" = "terraform"
}
+ location = (known after apply)
+ name = "k3s-control-plane-2"
+ rebuild_protection = false
+ server_type = "cx11"
+ ssh_keys = (known after apply)
+ status = (known after apply)
}
# hcloud_server_network.agents_network[0] will be created
+ resource "hcloud_server_network" "agents_network" {
+ id = (known after apply)
+ ip = "10.254.1.4"
+ mac_address = (known after apply)
+ server_id = (known after apply)
+ subnet_id = (known after apply)
}
# hcloud_server_network.agents_network[1] will be created
+ resource "hcloud_server_network" "agents_network" {
+ id = (known after apply)
+ ip = "10.254.1.5"
+ mac_address = (known after apply)
+ server_id = (known after apply)
+ subnet_id = (known after apply)
}
# hcloud_server_network.agents_network[2] will be created
+ resource "hcloud_server_network" "agents_network" {
+ id = (known after apply)
+ ip = "10.254.1.6"
+ mac_address = (known after apply)
+ server_id = (known after apply)
+ subnet_id = (known after apply)
}
# hcloud_server_network.control_planes[0] will be created
+ resource "hcloud_server_network" "control_planes" {
+ id = (known after apply)
+ ip = "10.254.1.1"
+ mac_address = (known after apply)
+ server_id = (known after apply)
+ subnet_id = (known after apply)
}
# hcloud_server_network.control_planes[1] will be created
+ resource "hcloud_server_network" "control_planes" {
+ id = (known after apply)
+ ip = "10.254.1.2"
+ mac_address = (known after apply)
+ server_id = (known after apply)
+ subnet_id = (known after apply)
}
# hcloud_server_network.control_planes[2] will be created
+ resource "hcloud_server_network" "control_planes" {
+ id = (known after apply)
+ ip = "10.254.1.3"
+ mac_address = (known after apply)
+ server_id = (known after apply)
+ subnet_id = (known after apply)
}
# hcloud_ssh_key.default will be created
+ resource "hcloud_ssh_key" "default" {
+ fingerprint = (known after apply)
+ id = (known after apply)
+ name = "K3S terraform module - Provisionning SSH key"
+ public_key = (known after apply)
}
# tls_private_key.ed25519-provisioning will be created
+ resource "tls_private_key" "ed25519-provisioning" {
+ algorithm = "ED25519"
+ ecdsa_curve = "P224"
+ id = (known after apply)
+ private_key_openssh = (sensitive value)
+ private_key_pem = (sensitive value)
+ private_key_pem_pkcs8 = (sensitive value)
+ public_key_fingerprint_md5 = (known after apply)
+ public_key_fingerprint_sha256 = (known after apply)
+ public_key_openssh = (known after apply)
+ public_key_pem = (known after apply)
+ rsa_bits = 2048
}
# module.k3s.null_resource.agents_drain["k3s-agent-0_node"] will be created
+ resource "null_resource" "agents_drain" {
+ id = (known after apply)
+ triggers = {
+ "agent_name" = "k3s-agent-0"
+ "connection_json" = (known after apply)
+ "drain_timeout" = "30s"
+ "kubectl_cmd" = "kubectl"
}
}
# module.k3s.null_resource.agents_drain["k3s-agent-1_node"] will be created
+ resource "null_resource" "agents_drain" {
+ id = (known after apply)
+ triggers = {
+ "agent_name" = "k3s-agent-1"
+ "connection_json" = (known after apply)
+ "drain_timeout" = "30s"
+ "kubectl_cmd" = "kubectl"
}
}
# module.k3s.null_resource.agents_drain["k3s-agent-2_node"] will be created
+ resource "null_resource" "agents_drain" {
+ id = (known after apply)
+ triggers = {
+ "agent_name" = "k3s-agent-2"
+ "connection_json" = (known after apply)
+ "drain_timeout" = "30s"
+ "kubectl_cmd" = "kubectl"
}
}
# module.k3s.null_resource.agents_install["k3s-agent-0_node"] will be created
+ resource "null_resource" "agents_install" {
+ id = (known after apply)
+ triggers = {
+ "on_immutable_changes" = "231c2099d0850d7cc82da54dad821067a7f24c4f"
+ "on_new_version" = "v1.27.1+k3s1"
}
}
# module.k3s.null_resource.agents_install["k3s-agent-1_node"] will be created
+ resource "null_resource" "agents_install" {
+ id = (known after apply)
+ triggers = {
+ "on_immutable_changes" = "231c2099d0850d7cc82da54dad821067a7f24c4f"
+ "on_new_version" = "v1.27.1+k3s1"
}
}
# module.k3s.null_resource.agents_install["k3s-agent-2_node"] will be created
+ resource "null_resource" "agents_install" {
+ id = (known after apply)
+ triggers = {
+ "on_immutable_changes" = "231c2099d0850d7cc82da54dad821067a7f24c4f"
+ "on_new_version" = "v1.27.1+k3s1"
}
}
# module.k3s.null_resource.agents_label["k3s-agent-0_node|node.kubernetes.io/pool"] will be created
+ resource "null_resource" "agents_label" {
+ id = (known after apply)
+ triggers = {
+ "agent_name" = "k3s-agent-0"
+ "connection_json" = (known after apply)
+ "kubectl_cmd" = "kubectl"
+ "label_name" = "node.kubernetes.io/pool"
+ "on_value_changes" = "gpu"
}
}
# module.k3s.null_resource.agents_label["k3s-agent-1_node|node.kubernetes.io/pool"] will be created
+ resource "null_resource" "agents_label" {
+ id = (known after apply)
+ triggers = {
+ "agent_name" = "k3s-agent-1"
+ "connection_json" = (known after apply)
+ "kubectl_cmd" = "kubectl"
+ "label_name" = "node.kubernetes.io/pool"
+ "on_value_changes" = "general"
}
}
# module.k3s.null_resource.agents_label["k3s-agent-2_node|node.kubernetes.io/pool"] will be created
+ resource "null_resource" "agents_label" {
+ id = (known after apply)
+ triggers = {
+ "agent_name" = "k3s-agent-2"
+ "connection_json" = (known after apply)
+ "kubectl_cmd" = "kubectl"
+ "label_name" = "node.kubernetes.io/pool"
+ "on_value_changes" = "general"
}
}
# module.k3s.null_resource.agents_taint["k3s-agent-0_node|dedicated"] will be created
+ resource "null_resource" "agents_taint" {
+ id = (known after apply)
+ triggers = {
+ "agent_name" = "k3s-agent-0"
+ "connection_json" = (known after apply)
+ "kubectl_cmd" = "kubectl"
+ "on_value_changes" = "gpu:NoSchedule"
+ "taint_name" = "dedicated"
}
}
# module.k3s.null_resource.k8s_ca_certificates_install[0] will be created
+ resource "null_resource" "k8s_ca_certificates_install" {
+ id = (known after apply)
}
# module.k3s.null_resource.k8s_ca_certificates_install[1] will be created
+ resource "null_resource" "k8s_ca_certificates_install" {
+ id = (known after apply)
}
# module.k3s.null_resource.k8s_ca_certificates_install[2] will be created
+ resource "null_resource" "k8s_ca_certificates_install" {
+ id = (known after apply)
}
# module.k3s.null_resource.k8s_ca_certificates_install[3] will be created
+ resource "null_resource" "k8s_ca_certificates_install" {
+ id = (known after apply)
}
# module.k3s.null_resource.k8s_ca_certificates_install[4] will be created
+ resource "null_resource" "k8s_ca_certificates_install" {
+ id = (known after apply)
}
# module.k3s.null_resource.k8s_ca_certificates_install[5] will be created
+ resource "null_resource" "k8s_ca_certificates_install" {
+ id = (known after apply)
}
# module.k3s.null_resource.kubernetes_ready will be created
+ resource "null_resource" "kubernetes_ready" {
+ id = (known after apply)
}
# module.k3s.null_resource.servers_drain["k3s-control-plane-0"] will be created
+ resource "null_resource" "servers_drain" {
+ id = (known after apply)
+ triggers = {
+ "connection_json" = (known after apply)
+ "drain_timeout" = "30s"
+ "kubectl_cmd" = "kubectl"
+ "server_name" = "k3s-control-plane-0"
}
}
# module.k3s.null_resource.servers_drain["k3s-control-plane-1"] will be created
+ resource "null_resource" "servers_drain" {
+ id = (known after apply)
+ triggers = {
+ "connection_json" = (known after apply)
+ "drain_timeout" = "30s"
+ "kubectl_cmd" = "kubectl"
+ "server_name" = "k3s-control-plane-1"
}
}
# module.k3s.null_resource.servers_drain["k3s-control-plane-2"] will be created
+ resource "null_resource" "servers_drain" {
+ id = (known after apply)
+ triggers = {
+ "connection_json" = (known after apply)
+ "drain_timeout" = "30s"
+ "kubectl_cmd" = "kubectl"
+ "server_name" = "k3s-control-plane-2"
}
}
# module.k3s.null_resource.servers_install["k3s-control-plane-0"] will be created
+ resource "null_resource" "servers_install" {
+ id = (known after apply)
+ triggers = {
+ "on_immutable_changes" = "5bbc5b363504fa478032f0d97c877f884a076d94"
+ "on_new_version" = "v1.27.1+k3s1"
}
}
# module.k3s.null_resource.servers_install["k3s-control-plane-1"] will be created
+ resource "null_resource" "servers_install" {
+ id = (known after apply)
+ triggers = {
+ "on_immutable_changes" = "5bbc5b363504fa478032f0d97c877f884a076d94"
+ "on_new_version" = "v1.27.1+k3s1"
}
}
# module.k3s.null_resource.servers_install["k3s-control-plane-2"] will be created
+ resource "null_resource" "servers_install" {
+ id = (known after apply)
+ triggers = {
+ "on_immutable_changes" = "5bbc5b363504fa478032f0d97c877f884a076d94"
+ "on_new_version" = "v1.27.1+k3s1"
}
}
# module.k3s.random_password.k3s_cluster_secret will be created
+ resource "random_password" "k3s_cluster_secret" {
+ bcrypt_hash = (sensitive value)
+ id = (known after apply)
+ length = 48
+ lower = true
+ min_lower = 0
+ min_numeric = 0
+ min_special = 0
+ min_upper = 0
+ number = true
+ numeric = true
+ result = (sensitive value)
+ special = false
+ upper = true
}
# module.k3s.tls_cert_request.master_user[0] will be created
+ resource "tls_cert_request" "master_user" {
+ cert_request_pem = (known after apply)
+ id = (known after apply)
+ key_algorithm = (known after apply)
+ private_key_pem = (sensitive value)
+ subject {
+ common_name = "master-user"
+ organization = "system:masters"
}
}
# module.k3s.tls_locally_signed_cert.master_user[0] will be created
+ resource "tls_locally_signed_cert" "master_user" {
+ allowed_uses = [
+ "key_encipherment",
+ "digital_signature",
+ "client_auth",
]
+ ca_cert_pem = (known after apply)
+ ca_key_algorithm = (known after apply)
+ ca_private_key_pem = (sensitive value)
+ cert_pem = (known after apply)
+ cert_request_pem = (known after apply)
+ early_renewal_hours = 0
+ id = (known after apply)
+ is_ca_certificate = false
+ ready_for_renewal = false
+ set_subject_key_id = false
+ validity_end_time = (known after apply)
+ validity_period_hours = 876600
+ validity_start_time = (known after apply)
}
# module.k3s.tls_private_key.kubernetes_ca[0] will be created
+ resource "tls_private_key" "kubernetes_ca" {
+ algorithm = "ECDSA"
+ ecdsa_curve = "P384"
+ id = (known after apply)
+ private_key_openssh = (sensitive value)
+ private_key_pem = (sensitive value)
+ private_key_pem_pkcs8 = (sensitive value)
+ public_key_fingerprint_md5 = (known after apply)
+ public_key_fingerprint_sha256 = (known after apply)
+ public_key_openssh = (known after apply)
+ public_key_pem = (known after apply)
+ rsa_bits = 2048
}
# module.k3s.tls_private_key.kubernetes_ca[1] will be created
+ resource "tls_private_key" "kubernetes_ca" {
+ algorithm = "ECDSA"
+ ecdsa_curve = "P384"
+ id = (known after apply)
+ private_key_openssh = (sensitive value)
+ private_key_pem = (sensitive value)
+ private_key_pem_pkcs8 = (sensitive value)
+ public_key_fingerprint_md5 = (known after apply)
+ public_key_fingerprint_sha256 = (known after apply)
+ public_key_openssh = (known after apply)
+ public_key_pem = (known after apply)
+ rsa_bits = 2048
}
# module.k3s.tls_private_key.kubernetes_ca[2] will be created
+ resource "tls_private_key" "kubernetes_ca" {
+ algorithm = "ECDSA"
+ ecdsa_curve = "P384"
+ id = (known after apply)
+ private_key_openssh = (sensitive value)
+ private_key_pem = (sensitive value)
+ private_key_pem_pkcs8 = (sensitive value)
+ public_key_fingerprint_md5 = (known after apply)
+ public_key_fingerprint_sha256 = (known after apply)
+ public_key_openssh = (known after apply)
+ public_key_pem = (known after apply)
+ rsa_bits = 2048
}
# module.k3s.tls_private_key.master_user[0] will be created
+ resource "tls_private_key" "master_user" {
+ algorithm = "ECDSA"
+ ecdsa_curve = "P384"
+ id = (known after apply)
+ private_key_openssh = (sensitive value)
+ private_key_pem = (sensitive value)
+ private_key_pem_pkcs8 = (sensitive value)
+ public_key_fingerprint_md5 = (known after apply)
+ public_key_fingerprint_sha256 = (known after apply)
+ public_key_openssh = (known after apply)
+ public_key_pem = (known after apply)
+ rsa_bits = 2048
}
# module.k3s.tls_self_signed_cert.kubernetes_ca_certs["0"] will be created
+ resource "tls_self_signed_cert" "kubernetes_ca_certs" {
+ allowed_uses = [
+ "digital_signature",
+ "key_encipherment",
+ "cert_signing",
]
+ cert_pem = (known after apply)
+ early_renewal_hours = 0
+ id = (known after apply)
+ is_ca_certificate = true
+ key_algorithm = (known after apply)
+ private_key_pem = (sensitive value)
+ ready_for_renewal = false
+ set_authority_key_id = false
+ set_subject_key_id = false
+ validity_end_time = (known after apply)
+ validity_period_hours = 876600
+ validity_start_time = (known after apply)
+ subject {
+ common_name = "kubernetes-client-ca"
}
}
# module.k3s.tls_self_signed_cert.kubernetes_ca_certs["1"] will be created
+ resource "tls_self_signed_cert" "kubernetes_ca_certs" {
+ allowed_uses = [
+ "digital_signature",
+ "key_encipherment",
+ "cert_signing",
]
+ cert_pem = (known after apply)
+ early_renewal_hours = 0
+ id = (known after apply)
+ is_ca_certificate = true
+ key_algorithm = (known after apply)
+ private_key_pem = (sensitive value)
+ ready_for_renewal = false
+ set_authority_key_id = false
+ set_subject_key_id = false
+ validity_end_time = (known after apply)
+ validity_period_hours = 876600
+ validity_start_time = (known after apply)
+ subject {
+ common_name = "kubernetes-server-ca"
}
}
# module.k3s.tls_self_signed_cert.kubernetes_ca_certs["2"] will be created
+ resource "tls_self_signed_cert" "kubernetes_ca_certs" {
+ allowed_uses = [
+ "digital_signature",
+ "key_encipherment",
+ "cert_signing",
]
+ cert_pem = (known after apply)
+ early_renewal_hours = 0
+ id = (known after apply)
+ is_ca_certificate = true
+ key_algorithm = (known after apply)
+ private_key_pem = (sensitive value)
+ ready_for_renewal = false
+ set_authority_key_id = false
+ set_subject_key_id = false
+ validity_end_time = (known after apply)
+ validity_period_hours = 876600
+ validity_start_time = (known after apply)
+ subject {
+ common_name = "kubernetes-request-header-key-ca"
}
}
Plan: 49 to add, 0 to change, 0 to destroy.
Changes to Outputs:
+ ssh_private_key = (sensitive value)
+ summary = {
+ agents = [
+ {
+ annotations = []
+ labels = {
+ "node.kubernetes.io/pool" = "gpu"
}
+ name = "k3s-agent-0"
+ taints = {
+ dedicated = "gpu:NoSchedule"
}
},
+ {
+ annotations = []
+ labels = {
+ "node.kubernetes.io/pool" = "general"
}
+ name = "k3s-agent-1"
+ taints = {
+ dedicated = null
}
},
+ {
+ annotations = []
+ labels = {
+ "node.kubernetes.io/pool" = "general"
}
+ name = "k3s-agent-2"
+ taints = {
+ dedicated = null
}
},
]
+ servers = [
+ {
+ annotations = {
+ server_id = 0
}
+ labels = []
+ name = "k3s-control-plane-0"
+ taints = []
},
+ {
+ annotations = {
+ server_id = 1
}
+ labels = []
+ name = "k3s-control-plane-1"
+ taints = []
},
+ {
+ annotations = {
+ server_id = 2
}
+ labels = []
+ name = "k3s-control-plane-2"
+ taints = []
},
]
+ version = "v1.27.1+k3s1"
}
|
github-actions
bot
removed
the
terraform:plan
Invoke Terraform plan workflow on the current PR
label
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #127