Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use k3s update channels for latest releases instead of github #28

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

solidnerd
Copy link
Contributor

Hey @xunleii,
thanks for this awesome terraform module. I did a fix to fetch the latest release rancher directly.

Closes #27

@xunleii
Copy link
Owner

xunleii commented Aug 2, 2020

Thanks a lot for your fix 😃. Don't worry about the CI, only the comment step failed (I currently don't know why). I will test it tomorrow after my day work and merge it manually.

@solidnerd
Copy link
Contributor Author

solidnerd commented Aug 2, 2020 via email

@xunleii xunleii merged commit bdcd84f into xunleii:master Aug 3, 2020
@xunleii
Copy link
Owner

xunleii commented Aug 3, 2020

Thanks for your contribution, it works like a charm :)
Just be careful with this module if you downscale then upscale your cluster, this issue still remaining (I will fix it in the next few weeks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or fix the 'latest' feature
2 participants