Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace network_id with subnet_id #30

Merged
merged 2 commits into from
Aug 5, 2020
Merged

fix: replace network_id with subnet_id #30

merged 2 commits into from
Aug 5, 2020

Conversation

solidnerd
Copy link
Contributor

Closes #29

@xunleii
Copy link
Owner

xunleii commented Aug 2, 2020 •
edited
Loading

Thanks for the fix and sorry for the CI, I will check it tomorrow.

@solidnerd
Copy link
Contributor Author

solidnerd commented Aug 2, 2020 via email

@xunleii
Copy link
Owner

xunleii commented Aug 3, 2020

There is a some formatting issues, so can you run terraform fmt -recursive ? Otherwise everything works, thank you again !

@solidnerd solidnerd force-pushed the fix-examples-for-hcloud-provider branch from c422147 to 1411df9 Compare August 5, 2020 10:24
@solidnerd
Copy link
Contributor Author

@xunleii Oh there was problem with my local setup. I did the formatting stuff.

@xunleii xunleii merged commit 27ee86f into xunleii:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation of network_id in hcloud_server_network
2 participants
@solidnerd @xunleii