Return notificationId from postLocalNotification (wix#610)

xvonabur · May 13, 2020 · d054818 · d054818
1 parent 22eedcb
commit d054818
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/src/commands/Commands.test.ts b/lib/src/commands/Commands.test.ts
@@ -119,6 +119,13 @@ describe('Commands', () => {
       uut.postLocalNotification(notification, passedId);
       verify(mockedNativeCommandsSender.postLocalNotification(notification, passedId)).called();
     });
+
+    it('return notification id', () => {
+      const notification: Notification = new Notification({identifier: 'id'});
+      const notificationId: number = 2;
+      const response = uut.postLocalNotification(notification, notificationId);
+      expect(response).toEqual(notificationId);
+    });
   });
 
   describe('getBadgeCount', () => {

diff --git a/lib/src/commands/Commands.ts b/lib/src/commands/Commands.ts
@@ -16,8 +16,8 @@ export class Commands {
 
   public postLocalNotification(notification: Notification, id?: number) {
     const notificationId: number = id ? id : this.uniqueIdProvider.generate();
-    const result = this.nativeCommandsSender.postLocalNotification(notification, notificationId);
-    return result;
+    this.nativeCommandsSender.postLocalNotification(notification, notificationId);
+    return notificationId;
   }
 
   public async getInitialNotification(): Promise<Notification | undefined> {