Skip to content

Commit

Permalink
Remove assert
Browse files Browse the repository at this point in the history
  • Loading branch information
frankiejarrett committed May 10, 2014
1 parent d75aa4a commit 767f7b2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion includes/class-wp-stream-author.php
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,13 @@ function get_avatar_img( $size = 80 ) {
*/
function get_avatar_src( $size = 80 ) {
$img = $this->get_avatar_img( $size );

if ( ! $img ) {
return false;
}
assert( preg_match( '/src=([\'"])(.*?)\1/', $img, $matches ) );

preg_match( '/src=([\'"])(.*?)\1/', $img, $matches );

This comment has been minimized.

Copy link
@shadyvb

shadyvb May 11, 2014

Contributor

@fjarrett I think we should check the result of this one, just in case the value is filtered/malformed by other plugins.

This comment has been minimized.

Copy link
@frankiejarrett

frankiejarrett May 11, 2014

Author Contributor

@shadyvb Sorry I missed you comment before the merge. I'm not sure exactly what you mean. Maybe you could provide the check you are thinking of here?

This comment has been minimized.

Copy link
@shadyvb

shadyvb May 12, 2014

Contributor

Carried out in #522


$src = html_entity_decode( $matches[2] );

return $src;
Expand Down

0 comments on commit 767f7b2

Please sign in to comment.