Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecation warning for missing page GET input #1440

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ocean90
Copy link
Contributor

@ocean90 ocean90 commented May 19, 2023

Also move the is_admin() check to the top for improved readability.

Fixes #1439.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Avoid deprecation warnings in PHP 8 for missing page GET input.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

Also move the `is_admin()` check to the top for improved readability.
Copy link

@kadamwhite kadamwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came here intending to open a similar PR, I can confirm that this patch fixes the warning we encountered.

Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@kasparsd kasparsd merged commit 91fd89c into xwp:develop Sep 13, 2023
@kasparsd kasparsd mentioned this pull request Oct 9, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
3 participants