Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving inline alerts #1620

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Fix saving inline alerts #1620

merged 3 commits into from
Nov 21, 2024

Conversation

pereirinha
Copy link
Member

@pereirinha pereirinha commented Oct 25, 2024

Fixes #1527.

The issue has 2 parts.

  1. Saving inline the Alert will fire the Admin AJAX inline_save action. In its internals, it expected information about the date and time of the post to be available as POST arguments. We are adding this information as hidden fields;
  2. There are cases where we are not saving a context or a connector. We should ensure a fallback;

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Ensure that WordPress's core inline_save action has all the information it needs to save the Stream Alert post type.
  • Fix: Handle partial data for Connector or Context

@pereirinha pereirinha force-pushed the fix/inline-save-alerts branch from 3d4077a to 12a8314 Compare October 29, 2024 10:19
Copy link
Collaborator

@marcinkrzeminski marcinkrzeminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pereirinha LGTM 🚀. I have tested this locally and can confirm the issue is gone. Related tests also are 🟢.

@marcinkrzeminski marcinkrzeminski merged commit cd040dd into develop Nov 21, 2024
2 checks passed
@marcinkrzeminski marcinkrzeminski deleted the fix/inline-save-alerts branch November 21, 2024 11:01
@marcinkrzeminski marcinkrzeminski added this to the 4.1.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AJAX Requests on Alerts Screen Contain Warnings
2 participants