Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Yoast connector test #1625

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix Yoast connector test #1625

merged 1 commit into from
Nov 20, 2024

Conversation

pereirinha
Copy link
Member

Fixes #1594.

Takes into consideration the conditional check for Yoast version introduced.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

marcinkrzeminski
marcinkrzeminski approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@marcinkrzeminski marcinkrzeminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pereirinha this works. Thank you very much.

@marcinkrzeminski marcinkrzeminski merged commit 6f886fe into develop Nov 20, 2024
1 check passed
@marcinkrzeminski marcinkrzeminski deleted the fix/yoast-connector-test branch November 20, 2024 15:05
@marcinkrzeminski marcinkrzeminski added this to the 4.1.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinkrzeminski marcinkrzeminski marcinkrzeminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
2 participants
@pereirinha @marcinkrzeminski