Change priority of connectors load to be after widgets_init #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fjarrett /megafive! |
frankiejarrett
added a commit
that referenced
this pull request
May 15, 2014
Change priority of connectors load to be after widgets_init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531
The problem was that you can't call
global $wp_registered_sidebarsuntil theinithook has fired with a priority of 1, which is whenwigets_inithappens. See the special note aboutwidgets_initin the Codex Action Reference.So by loading connectors on
initwith a priority of 9 we are able to get the sidebar names correctly and also prevent regression on #501 because we only miss the user login/logout when usinginitwith a priority 10.I think it's better to fire as close to the default priority as we can rather than as far away from it as we can, just in case other plugins (or core) introduce globals on lower priorities that Stream would need.
No upgrade routine is needed for this as all previous records will now query the
get_context_labelsmethod successfully. MVC approach FTW!