Gravity Forms connector update - bugfix/issue-771 #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rob - where are we at with this? |
|
Hi @lukecarbis - sorry, almost done (busy work week at my 'normal' job.) I will hopefully have everything committed tonight! |
|
@rob Ready for me to test? |
|
Hi @lukecarbis - sorry for the delays, my day job has been very busy lately. I did manage to do some work and clean up a lot of stuff, and it should work as it stands right now without any errors. But there's still some actions and other stuff I want to go over and clean up still, so it's your call. |
lukecarbis
pushed a commit
that referenced
this pull request
Nov 6, 2015
Gravity Forms connector update - bugfix/issue-771
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #779 with some more fixes. (also see #771)
FYI: All of the current GF export/import tracking functionality is broken in Stream. There's no longer a way to track form exports (and this was causing a bug - see below), and the actions for exporting entries and importing forms has changed. This commit fixes export/import tracking.
I also bumped
PLUGIN_MIN_VERSIONdue to the newgform_forms_post_importaction introduced in1.9.13.29(latest stable release.)I discovered a bug in the current version. The
gform_export_formline (which is actually a filter, not action) was causing the Gravity Forms .json export file to be empty. After removing that line, exports are working fine.