Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list table design at smaller screen size #810

Merged
merged 3 commits into from
Feb 26, 2016
Merged

Conversation

lukecarbis
Copy link
Contributor

Resolves #804.

@ocean90 Please review, let me know if this works for you. :)

@lukecarbis
Copy link
Contributor Author

@Chacha Can you please review this PR?

@tylerhcarter
Copy link
Contributor

@lukecarbis Could not reproduce in trunk. Could reproduce in stable. Functionally it works.

I looked to see if there was a simple way we could make this happen without using the !important, but given the complexity of the overriding rule, I think its the best solution here.

@tylerhcarter
Copy link
Contributor

Created bugfix/issue-804a that has been updated with the fixes to Travis.

@lukecarbis
Copy link
Contributor Author

@Chacha - Travis fixes have been merged into develop, and I've merged develop into this branch. Anything else needed before I test / merge this fix?

@tylerhcarter
Copy link
Contributor

@lukecarbis I think you're good. I'll go ahead and delete the bugfix/issue-804a branch and you should be set to merge.

@lukecarbis
Copy link
Contributor Author

@Chacha Made a couple of CSS changes - could you please test? If you and Travis are okay with it, please merge.

@tylerhcarter
Copy link
Contributor

Looks great! 👍

On Feb 25, 2016, at 8:44 PM, Luke Carbis notifications@github.com wrote:

@Chacha https://github.com/chacha Made a couple of CSS changes - could you please test? If you and Travis are okay with it, please merge.


Reply to this email directly or view it on GitHub #810 (comment).

lukecarbis pushed a commit that referenced this pull request Feb 26, 2016
Update list table design at smaller screen size
@lukecarbis lukecarbis merged commit d4c4474 into develop Feb 26, 2016
@lukecarbis lukecarbis deleted the bugfix/issue-804 branch February 26, 2016 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants