Allow adding additional query vars #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weston Added the |
westonruter
suggested changes
Oct 5, 2016
miina
changed the title
miina
commented
Oct 5, 2016
| @@ -291,6 +291,8 @@ public function process_post_query_vars( $post_query_vars ) { | |||
| 'order', | |||
| ); | |||
|
|
|||
| $allowed_query_vars = apply_filters( 'customize_object_selector_query_posts_allowed_vars', $allowed_query_vars ); | |||
There was a problem hiding this comment.
Maybe we should throw an error in case this returns null since then all the vars would be allowed. Or maybe in case of null we should set it to array() which will throw an error with $extra_query_vars. Thoughts?
There was a problem hiding this comment.
@miina there's no need for this customize_object_selector_query_posts_allowed_vars filter now because the opt-in will instead be accounted for below in the customize_object_selector_post_query_vars filter.
There was a problem hiding this comment.
💡 Of course not, doh. Will remove.
westonruter
approved these changes
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.