Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how the plugin guess the sources absolute paths #39

Merged
merged 1 commit into from
Sep 29, 2013
Merged

Improve how the plugin guess the sources absolute paths #39

merged 1 commit into from
Sep 29, 2013

Conversation

nash-ye
Copy link
Contributor

@nash-ye nash-ye commented Sep 27, 2013

Fix #34

westonruter
westonruter reviewed Sep 29, 2013
View reviewed changes
dependency-minification.php
if ( ! $has_host ) {
$src = 'http://' . $host_domain . $src;

if ( ! preg_match( '|^(https?:)?//|', $src ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nash-ye oops! Syntax error. Forgot { to match the } below. I'll supply.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7d9e363

westonruter added a commit that referenced this pull request Sep 29, 2013
@westonruter
Improve how the plugin guesses the sources' absolute paths
f53e8d7 
Fixes #34
Closes #39

Merge branch 'nash-ye-develop' into develop
@westonruter westonruter merged commit 0336aae into xwp:develop Sep 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nash-ye @westonruter