This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Gitlab Integration #253
Merged
Gitlab Integration #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
reviewed
Aug 10, 2017
check-diff.sh
Outdated
| @@ -69,6 +69,9 @@ function set_environment_variables { | |||
| DIFF_BASE=${DIFF_BASE:-$TRAVIS_COMMIT^} | |||
| fi | |||
| DIFF_HEAD=${DIFF_HEAD:-$TRAVIS_COMMIT} | |||
| elif [[ ! -z "${GITLAB_CI}" ]]; then | |||
| DIFF_BASE=${DIFF_BASE:-master} | |||
There was a problem hiding this comment.
Let's update this to use $DEFAULT_BASE_BRANCH from #229.
westonruter
reviewed
Aug 10, 2017
| npm config set prefix $TEMP_DIRECTORY | ||
| export NODE_PATH=$TEMP_DIRECTORY/lib/node_modules:$NODE_PATH | ||
| export PATH=$TEMP_DIRECTORY/bin:$PATH | ||
| fi |
There was a problem hiding this comment.
This can be eliminated once #252 is resolved.
|
Should we add |
|
@PatelUtkarsh I don't think we have enough experience with Gitlab CI to suggest a best practice sample config. Once IBD is 100% sorted I think we can circle back and add one though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.