Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS Widgets as Shortcodes (Post Elements) with Shortcode UI (via Shortcake) #32

Merged
merged 22 commits into from
Feb 17, 2017

Conversation

westonruter
Copy link
Contributor

@westonruter westonruter commented Jan 12, 2017

  • Ensure that \WP_JS_Widget::$icon_name gets exported to an inline style rules to apply to the widgets listed in the customizer.
  • Factor out the Shortcake-specific PHP logic from the main Plugin class into another Shortcake-specific integration class.
  • Pages widget dropdown fails to parse/restore previously-selected exclusions in Select2 dropdown.
  • Ensure that widget can be previewed via shortcake and drafted in post content. (Irrelevant since the widget instance data is inline.)
  • Let widget instance data be encoded as JSON in a shortcode attribute.
  • Re-use the dashicon associated with a given widget in the customizer to also be used for the Post Element browser in the editor:
    image
  • Ensure that base styles for widgets are included in widget-form.css so that elements will appear as expected, and not like this:
    image
  • Update Nav Menu widget's Edit Menu button to work as expected, to be hidden when no menu is selected and to work properly in a Shortcake context.

Fixes #11.

@westonruter westonruter changed the title WIP: Add JS Widgets as Shortcodes (Post Elements) with Shortcode UI (via Shortcake) Add JS Widgets as Shortcodes (Post Elements) with Shortcode UI (via Shortcake) Feb 17, 2017
@westonruter
Copy link
Contributor Author

This is ready for final testing and merging now.

@westonruter westonruter added this to the 0.4.0 milestone Feb 17, 2017
@westonruter westonruter merged commit 38c0169 into develop Feb 17, 2017
@westonruter westonruter deleted the feature/shortcake-integration branch February 17, 2017 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant