-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JavaScript unit tests and refactor #35
Commits on Jan 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 20e2430 - Browse repository at this point
Copy the full SHA 20e2430View commit details -
Alter extendWidgetControl to a (mostly) pure function
Changes the function to accept an object, alter that object's prototype, and return it. The caller is then responsible for passing the constructor function to change. This allows the function to be more easily tested since it does not directly mutate global variables (although of course changing the prototype of a global variable will have a a global effect). Also adds `wp` and `_` as parameters to the IIFE to make their usage explicit.
Configuration menu - View commit details
-
Copy full SHA for d64c61f - Browse repository at this point
Copy the full SHA d64c61fView commit details -
Add truthy test for isJsWidgetControl
Not currently using real Controls, but it's something.
Configuration menu - View commit details
-
Copy full SHA for 1fe1906 - Browse repository at this point
Copy the full SHA 1fe1906View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2dcb33 - Browse repository at this point
Copy the full SHA e2dcb33View commit details
Commits on Jan 23, 2017
-
Explicitly pass underscore to the IIFE
IIFEs are good tools for encapsulating functionality and to maintain that encapsulation, all inputs and outputs (the exported API) need to be explicit. To simply alias variables, variable assignment is a less cumbersome tool.
Configuration menu - View commit details
-
Copy full SHA for 26915f7 - Browse repository at this point
Copy the full SHA 26915f7View commit details -
Remove unnecessary use of
_.clone
`_.clone()` only performs a shallow copy and `_.extend()` is already doing that here.
Configuration menu - View commit details
-
Copy full SHA for 8c34cfe - Browse repository at this point
Copy the full SHA 8c34cfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cc5229 - Browse repository at this point
Copy the full SHA 9cc5229View commit details
Commits on Jan 31, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 739150e - Browse repository at this point
Copy the full SHA 739150eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e66457 - Browse repository at this point
Copy the full SHA 9e66457View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99c9ae2 - Browse repository at this point
Copy the full SHA 99c9ae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba2700d - Browse repository at this point
Copy the full SHA ba2700dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d2ad13 - Browse repository at this point
Copy the full SHA 1d2ad13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 187ac67 - Browse repository at this point
Copy the full SHA 187ac67View commit details -
Configuration menu - View commit details
-
Copy full SHA for e296998 - Browse repository at this point
Copy the full SHA e296998View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d3e100 - Browse repository at this point
Copy the full SHA 5d3e100View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9cab13 - Browse repository at this point
Copy the full SHA c9cab13View commit details -
Remove adding missing title property to model in sanitize
This does not seem necessary.
Configuration menu - View commit details
-
Copy full SHA for ce79ba4 - Browse repository at this point
Copy the full SHA ce79ba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c99186 - Browse repository at this point
Copy the full SHA 3c99186View commit details -
Configuration menu - View commit details
-
Copy full SHA for 778bc95 - Browse repository at this point
Copy the full SHA 778bc95View commit details -
Configuration menu - View commit details
-
Copy full SHA for f531a00 - Browse repository at this point
Copy the full SHA f531a00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 235cf1d - Browse repository at this point
Copy the full SHA 235cf1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b19fba3 - Browse repository at this point
Copy the full SHA b19fba3View commit details -
Add Form.renderNotificationsToContainer to allow testing
Debounced functions are async by nature and harder to test. This rewrites `renderNotifications` as a debounced proxy for `renderNotificationsToContainer`.
Configuration menu - View commit details
-
Copy full SHA for 25b27ae - Browse repository at this point
Copy the full SHA 25b27aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f3d014 - Browse repository at this point
Copy the full SHA 7f3d014View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff9ff09 - Browse repository at this point
Copy the full SHA ff9ff09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dc6349 - Browse repository at this point
Copy the full SHA 4dc6349View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce7b650 - Browse repository at this point
Copy the full SHA ce7b650View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19f752a - Browse repository at this point
Copy the full SHA 19f752aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5976cc7 - Browse repository at this point
Copy the full SHA 5976cc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cad5b6a - Browse repository at this point
Copy the full SHA cad5b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb7bf73 - Browse repository at this point
Copy the full SHA cb7bf73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7be5641 - Browse repository at this point
Copy the full SHA 7be5641View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b08fdf - Browse repository at this point
Copy the full SHA 1b08fdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6361e7c - Browse repository at this point
Copy the full SHA 6361e7cView commit details
Commits on Feb 2, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5bbceca - Browse repository at this point
Copy the full SHA 5bbcecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for bafd1b9 - Browse repository at this point
Copy the full SHA bafd1b9View commit details -
Rename renderNotificationsTemplate to renderMarkupToContainer
The previous helper had too many arguments
Configuration menu - View commit details
-
Copy full SHA for c0e778e - Browse repository at this point
Copy the full SHA c0e778eView commit details
Commits on Feb 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0602b2f - Browse repository at this point
Copy the full SHA 0602b2fView commit details -
Explicitly pluck Form arguments when assigning
Only allows `model` and `container`, ignoring all other properties.
Configuration menu - View commit details
-
Copy full SHA for 6f707e1 - Browse repository at this point
Copy the full SHA 6f707e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b06d226 - Browse repository at this point
Copy the full SHA b06d226View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2e5a0d - Browse repository at this point
Copy the full SHA c2e5a0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff48f63 - Browse repository at this point
Copy the full SHA ff48f63View commit details
Commits on Feb 6, 2017
-
Move Form private functions to bottom of file
It's easier to read the purpose of the file if the class comes first.
Configuration menu - View commit details
-
Copy full SHA for 5255291 - Browse repository at this point
Copy the full SHA 5255291View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2145662 - Browse repository at this point
Copy the full SHA 2145662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 379af12 - Browse repository at this point
Copy the full SHA 379af12View commit details
Commits on Feb 10, 2017
-
Change tests so that validate becomes a method on Form
This replaces overriding the `model.validate` method by requiring using `form.setState()` to update the model
Configuration menu - View commit details
-
Copy full SHA for dae04c6 - Browse repository at this point
Copy the full SHA dae04c6View commit details -
Move model.validate to Form.validate
Form.validate is now called by Form.setState. This avoids mutating the model.
Configuration menu - View commit details
-
Copy full SHA for c63043c - Browse repository at this point
Copy the full SHA c63043cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ba065a - Browse repository at this point
Copy the full SHA 8ba065aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33ed378 - Browse repository at this point
Copy the full SHA 33ed378View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f8f62b - Browse repository at this point
Copy the full SHA 5f8f62bView commit details
Commits on Feb 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 02b0a1c - Browse repository at this point
Copy the full SHA 02b0a1cView commit details -
Modify createSyncedPropertyValue to use setState
This makes sure that data from the DOM is validated before changing the model.
Configuration menu - View commit details
-
Copy full SHA for 6bc2e66 - Browse repository at this point
Copy the full SHA 6bc2e66View commit details
Commits on Feb 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4f5aa12 - Browse repository at this point
Copy the full SHA 4f5aa12View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0cb61f - Browse repository at this point
Copy the full SHA a0cb61fView commit details
Commits on Feb 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 067c045 - Browse repository at this point
Copy the full SHA 067c045View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d7ccb0 - Browse repository at this point
Copy the full SHA 5d7ccb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2688244 - Browse repository at this point
Copy the full SHA 2688244View commit details -
Configuration menu - View commit details
-
Copy full SHA for e796fed - Browse repository at this point
Copy the full SHA e796fedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29af225 - Browse repository at this point
Copy the full SHA 29af225View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b495c9 - Browse repository at this point
Copy the full SHA 2b495c9View commit details
Commits on Feb 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a1c9533 - Browse repository at this point
Copy the full SHA a1c9533View commit details -
Configuration menu - View commit details
-
Copy full SHA for caa5b49 - Browse repository at this point
Copy the full SHA caa5b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7f8d07 - Browse repository at this point
Copy the full SHA a7f8d07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5194115 - Browse repository at this point
Copy the full SHA 5194115View commit details
Commits on Feb 16, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8562511 - Browse repository at this point
Copy the full SHA 8562511View commit details