Add JavaScript unit tests and refactor #35
Commits on Jan 20, 2017
-
-
Alter extendWidgetControl to a (mostly) pure function
Changes the function to accept an object, alter that object's prototype, and return it. The caller is then responsible for passing the constructor function to change. This allows the function to be more easily tested since it does not directly mutate global variables (although of course changing the prototype of a global variable will have a a global effect). Also adds `wp` and `_` as parameters to the IIFE to make their usage explicit.
-
Add truthy test for isJsWidgetControl
Not currently using real Controls, but it's something.
-
Commits on Jan 23, 2017
-
Explicitly pass underscore to the IIFE
IIFEs are good tools for encapsulating functionality and to maintain that encapsulation, all inputs and outputs (the exported API) need to be explicit. To simply alias variables, variable assignment is a less cumbersome tool.
-
Remove unnecessary use of
_.clone`_.clone()` only performs a shallow copy and `_.extend()` is already doing that here.
-
Commits on Jan 31, 2017
-
-
-
-
-
-
-
-
Remove adding missing title property to model in sanitize
This does not seem necessary.
-
-
-
-
-
-
Add Form.renderNotificationsToContainer to allow testing
Debounced functions are async by nature and harder to test. This rewrites `renderNotifications` as a debounced proxy for `renderNotificationsToContainer`.
-
-
-
-
-
-
-
-
-
-
Commits on Feb 2, 2017
-
-
-
Rename renderNotificationsTemplate to renderMarkupToContainer
The previous helper had too many arguments
Commits on Feb 4, 2017
-
Explicitly pluck Form arguments when assigning
Only allows `model` and `container`, ignoring all other properties.
-
Commits on Feb 6, 2017
-
Move Form private functions to bottom of file
It's easier to read the purpose of the file if the class comes first.
-
-
Commits on Feb 10, 2017
-
Change tests so that validate becomes a method on Form
This replaces overriding the `model.validate` method by requiring using `form.setState()` to update the model
-
Move model.validate to Form.validate
Form.validate is now called by Form.setState. This avoids mutating the model.
-
-
-
Commits on Feb 11, 2017
-
-
Modify createSyncedPropertyValue to use setState
This makes sure that data from the DOM is validated before changing the model.